sync local pi changes
This commit is contained in:
44
.pi/reviews/context-manager-task6-fix-report.md
Normal file
44
.pi/reviews/context-manager-task6-fix-report.md
Normal file
@@ -0,0 +1,44 @@
|
||||
# Context Manager Task 6 Fix Report
|
||||
|
||||
## Status
|
||||
- Completed
|
||||
- Task 6 review findings addressed in the context-manager extension
|
||||
- Verification commands requested in the task were run and passed
|
||||
|
||||
## Changes
|
||||
- Added authoritative branch rebuild logic in `.pi/agent/extensions/context-manager/index.ts`.
|
||||
- Syncs the runtime context window
|
||||
- Reads the latest valid snapshot from `ctx.sessionManager.getBranch()`
|
||||
- Restores snapshot metadata with an empty ledger
|
||||
- Replays `user`, `assistant`, and `toolResult` messages from the active branch into the runtime
|
||||
- Refreshes the footer status from the rebuilt runtime
|
||||
- Hooked that rebuild logic into:
|
||||
- `session_start`
|
||||
- `turn_end` (before snapshot persistence)
|
||||
- `session_tree`
|
||||
- Kept incremental `tool_result` ingestion for in-turn responsiveness, but the branch rebuild is now authoritative at synchronization points.
|
||||
- Tightened some extension-boundary typing in `index.ts` while making the fix.
|
||||
- Replaced the shallow registration-only test with integration-style coverage that exercises the registered handlers.
|
||||
|
||||
## Tests
|
||||
- `cd /home/alex/dotfiles/.worktrees/context-manager-extension/.pi/agent/extensions/context-manager && npx tsx --test src/extension.test.ts`
|
||||
- Passed: 3/3
|
||||
- `cd /home/alex/dotfiles/.worktrees/context-manager-extension/.pi/agent/extensions/context-manager && npm test`
|
||||
- Passed: 38/38
|
||||
- `cd /home/alex/dotfiles/.worktrees/context-manager-extension && git diff --check -- .pi/agent/extensions/context-manager/index.ts .pi/agent/extensions/context-manager/src/extension.test.ts`
|
||||
- Passed with no diff/whitespace errors
|
||||
|
||||
## Files Changed
|
||||
- `.pi/agent/extensions/context-manager/index.ts`
|
||||
- `.pi/agent/extensions/context-manager/src/extension.test.ts`
|
||||
- `.pi/reviews/context-manager-task6-fix-report.md`
|
||||
|
||||
## Self-review Findings
|
||||
- `turn_end` now persists snapshots built from the actual current branch, so the ledger includes facts extracted from branch `user` and `assistant` messages instead of depending on `tool_result` events alone.
|
||||
- `session_tree` now resets runtime state immediately after navigation, so the next `context` packet reflects the destination branch instead of the abandoned one.
|
||||
- The new tests invoke real registered handlers and verify behavior, not just registration names.
|
||||
- Public command names and extension surface area remained unchanged.
|
||||
|
||||
## Concerns
|
||||
- No blocking concerns.
|
||||
- Note: branch-local mode changes made via `/ctx-mode` are still persisted on the next `turn_end` snapshot. If a branch has no snapshot yet, restoration falls back to default branch state until a snapshot exists. This was left unchanged to keep the Task 6 fix focused.
|
||||
Reference in New Issue
Block a user