feat: add plan and review workflow skills
This commit is contained in:
61
.config/opencode/skills/requesting-code-review/SKILL.md
Normal file
61
.config/opencode/skills/requesting-code-review/SKILL.md
Normal file
@@ -0,0 +1,61 @@
|
||||
---
|
||||
name: requesting-code-review
|
||||
description: Request a reviewer pass after each task or feature and before merge to catch issues early
|
||||
permalink: opencode-config/skills/requesting-code-review/skill
|
||||
---
|
||||
|
||||
# Requesting Code Review
|
||||
|
||||
Request a `reviewer` agent pass before changes move forward or merge.
|
||||
|
||||
## Core Workflow
|
||||
|
||||
Request review:
|
||||
- After a completed task in a multi-task implementation
|
||||
- After finishing a feature slice
|
||||
- Before opening or merging a PR
|
||||
|
||||
Include all required context in the request:
|
||||
- What was implemented
|
||||
- Requirements or plan source (for example, `plans/<note-name>` in basic-memory)
|
||||
- Brief summary of behavior and design choices
|
||||
- Actual diff context (commit range and/or key changed files)
|
||||
|
||||
## How to Run It
|
||||
|
||||
1. Gather concrete diff context for the exact review scope:
|
||||
|
||||
```bash
|
||||
BASE_SHA=$(git merge-base HEAD origin/$(git rev-parse --abbrev-ref @{upstream} | cut -d/ -f2 2>/dev/null || echo main))
|
||||
HEAD_SHA=$(git rev-parse HEAD)
|
||||
|
||||
git diff --stat "$BASE_SHA..$HEAD_SHA"
|
||||
git diff "$BASE_SHA..$HEAD_SHA"
|
||||
```
|
||||
|
||||
2. Dispatch `reviewer` with a focused request using:
|
||||
- exact implemented scope
|
||||
- the relevant `plans/` note or requirement text
|
||||
- a concise summary
|
||||
- the concrete diff range (`BASE_SHA..HEAD_SHA`) and any key files
|
||||
|
||||
Use `reviewer.md` as a request template.
|
||||
|
||||
3. Triage feedback before continuing:
|
||||
- Fix critical issues immediately
|
||||
- Address important issues before merge
|
||||
- Track minor issues intentionally
|
||||
- If feedback appears incorrect, reply with code/test evidence and request clarification
|
||||
|
||||
## Red Flags
|
||||
|
||||
Never:
|
||||
- Skip review because a change seems small
|
||||
- Continue with unresolved critical issues
|
||||
- Request review without plan/requirement context
|
||||
- Request review without concrete diff scope
|
||||
|
||||
## Related Skills
|
||||
|
||||
- `verification-before-completion`
|
||||
- `git-workflow`
|
||||
49
.config/opencode/skills/requesting-code-review/reviewer.md
Normal file
49
.config/opencode/skills/requesting-code-review/reviewer.md
Normal file
@@ -0,0 +1,49 @@
|
||||
---
|
||||
title: reviewer-request-template
|
||||
type: note
|
||||
permalink: opencode-config/skills/requesting-code-review/reviewer-template
|
||||
---
|
||||
|
||||
# Reviewer Request Template
|
||||
|
||||
Use this when dispatching the `reviewer` agent.
|
||||
|
||||
## What Was Implemented
|
||||
|
||||
<what-was-implemented>
|
||||
|
||||
## Requirements / Plan
|
||||
|
||||
- Plan note: `plans/<note-name>`
|
||||
- Requirements summary:
|
||||
- <requirement-1>
|
||||
- <requirement-2>
|
||||
|
||||
## Summary
|
||||
|
||||
<brief summary of behavior/design choices>
|
||||
|
||||
## Diff Context
|
||||
|
||||
- Base: <base-sha>
|
||||
- Head: <head-sha>
|
||||
- Range: `<base-sha>..<head-sha>`
|
||||
- Key files:
|
||||
- <path-1>
|
||||
- <path-2>
|
||||
|
||||
```bash
|
||||
git diff --stat <base-sha>..<head-sha>
|
||||
git diff <base-sha>..<head-sha>
|
||||
```
|
||||
|
||||
## Reviewer Output Requested
|
||||
|
||||
1. Strengths
|
||||
2. Issues by severity:
|
||||
- Critical (must fix)
|
||||
- Important (should fix before merge)
|
||||
- Minor (nice to have)
|
||||
3. Merge readiness verdict with short reasoning
|
||||
|
||||
For each issue include file:line, why it matters, and suggested fix.
|
||||
Reference in New Issue
Block a user